phpcbf service-front/app/features #2405
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Run phpcbf (phpcs fixer) to fix code in service-front . Ensure everything still works.
Fixes UML-2906
Approach
phpcbf run on service-front/app/features and service-front/app/test. Errors have also been fixed manually using phpcs.
Learning
Checklist
[ ] I have added relevant logging with appropriate levels to my code[ ] New event_codes have been documented on the [wiki page]~~(https://opgtransform.atlassian.net/wiki/spaces/LSML2/pages/3277881441/Understanding+the+event+logs)[ ] I have updated documentation (Confluence/GitHub wiki/tech debt doc) where relevant[ ] I have added tests to prove my work*~ [ ] I have added welsh translation tags and updated translation files~
[ ] I have run an accessibility tool on any pages I have made changes to and fixed any issues found[ ] I have notified the Interaction Designer of any content changes so that appropriate screenshots/flow diagram changes can be made*~ [ ] The product team have tested these changes~